iOS: Fix a few instances of UB #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay! This LGTM, but I'm currently unemployed and therefore no longer have any iOS devices to test on. @ArthurKValladares would you mind taking a look at this? |
This was referenced Aug 31, 2022
|
I merged this as per discussion in #2451 |
kchibisov
pushed a commit
to kchibisov/winit
that referenced
this pull request
Sep 9, 2022
* Fix iOS 32-bit * Fix a few invalid message sends on iOS
kchibisov
pushed a commit
that referenced
this pull request
Sep 11, 2022
* Fix iOS 32-bit * Fix a few invalid message sends on iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly interesting for 32-bit iOS.
Found while making #2427.
CHANGELOG.mdif knowledge of this change could be valuable to users