New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CI run on changes to non-code files as well #2130
Conversation
Ideally, we'd have CI skip any code-checking steps if no source code was touched, instead of running all the steps all of the time, but that's also a bit more complicated to set up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Running CI on all PRs is not that expensive and is far safer as there are a lot of ways to break things outside of changing code.
The repository is configured such that specific checks are required to pass before merging; since CI doesn't run on PRs that don't change code, they can't be merged without administrator intervention. Also, while this definition is currently correct, we might in the future change something so that changes to other files (like markdown files) really should be run through CI. And example of that could be: ```rust #[cfg(doctest)] #[doc = include_str!("../README.md")] extern "C" {} ```
c16621f
to
359ea76
Compare
Also not something neither you nor I can fix, I think it's part of the repo settings that only an admin/"owner" can access? |
It's something a more sophisticated CI config could solve. |
Fair enough, I'll gladly admit I don't know enough about GitHub Actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This, while somewhat wasteful, is probably nicer than having to circumvent the "CI passes" check.
We should probably try to get a more granular CI config set up eventually.
The repository is configured such that specific checks are required to pass before merging; since CI doesn't run on PRs that don't change code, they can't be merged without administrator intervention.
Currently affecting #2126, and has affected many others in the past.
Also, while this definition is currently correct, we might in the future change something so that changes to other files (like markdown files) really should be run through CI.
CHANGELOG.md
if knowledge of this change could be valuable to users