Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.26.1 #2125

Merged
merged 1 commit into from Jan 5, 2022
Merged

Release 0.26.1 #2125

merged 1 commit into from Jan 5, 2022

Conversation

ArturKovacs
Copy link
Contributor

@ArturKovacs ArturKovacs commented Jan 2, 2022 •
edited by madsmtm

v0.26.0 had a regression that made the Pinyin IME input unusable on macOS. See #2097

#2119 fixed that regression, and I think it's a good idea to publish a new release with the fix quickly.

Blocked on:

Sorry for the noise, I realized that I shouldn't have created the issue.

@ArturKovacs
Copy link
Contributor Author

@madsmtm for whatever reason GitHub won't let me add you as a reviewer. But I want you to review this regardless :D

@ArturKovacs ArturKovacs mentioned this pull request Jan 2, 2022
Closed
madsmtm
madsmtm approved these changes Jan 2, 2022
View reviewed changes
Copy link
Member

@madsmtm madsmtm left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's!

Can I request getting #2078 in as well? The way rustc works in this regard will probably change at some point again, and the sooner we get this fix out the better.

@madsmtm
Copy link
Member

madsmtm commented Jan 2, 2022

@madsmtm for whatever reason GitHub won't let me add you as a reviewer

Probably because I'm not part of the @rust-windowing organization yet.

@maroider
Copy link
Member

maroider commented Jan 2, 2022

Probably because I'm not part of the @rust-windowing organization yet.

Ah, right, cc @francesca64

@maroider
Copy link
Member

maroider commented Jan 2, 2022

I'd like to get in #2025 if possible.

@msiglreith
Copy link
Member

#2121 might be a candidate as well, just missing a changelog entry. The regression affects some users from egui.

@ArturKovacs
Copy link
Contributor Author

Yeah let's wait a day or two for #2078, #2025, and #2121 to get merged.

msiglreith
msiglreith approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@msiglreith msiglreith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

date should be updated

@ArturKovacs ArturKovacs merged commit d3e6949 into rust-windowing:master Jan 5, 2022
@ArturKovacs ArturKovacs deleted the release-0.26.1 branch January 5, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msiglreith msiglreith msiglreith approved these changes

@madsmtm madsmtm madsmtm approved these changes

@kchibisov kchibisov kchibisov approved these changes

@maroider maroider maroider approved these changes

@francesca64 francesca64 Awaiting requested review from francesca64

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ArturKovacs @madsmtm @maroider @msiglreith @kchibisov