Fix transparent window crash on Windows 11 #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe the transparent setting in WM_NCCREATE on Windows 11 will cause a block when calling DwmEnableBlureBehindWindow and will crash. Puts them into WM_CREATE and it works.
maroider
added
DS - windows
C - waiting on maintainer
msiglreith
approved these changes
Jan 2, 2022
|
Could you add a changelog entry please? |
msiglreith
removed
the
C - waiting on maintainer
Update CHANGELOG.md for Win11 transparent window issue
Sorry for forgetting it. It was added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe the transparent setting in WM_NCCREATE on Windows 11 will cause a block when callling DwmEnableBlureBehindWindow and will crash. Puts them into WM_CREATE and it works. #2082
I have not found any details about the behavior change on Windows 11. Perhaps it's could be a Win11 bug.
I have no win8 or earlier enviroment so I can't test them on these platforms.
cargo fmthas been run on this branchcargo docbuilds successfullyCHANGELOG.mdif knowledge of this change could be valuable to users