Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Split window initialization across NCCREATE and CREATE #2062

Merged
merged 3 commits into from Nov 17, 2021
Merged

Windows: Split window initialization across NCCREATE and CREATE #2062

merged 3 commits into from Nov 17, 2021

Conversation

msiglreith
Copy link
Member

Fixes #2060

Doing all the initialization steps inside WM_NCCREATE doesn't seem to work out (see issue) - aspects affecting the client area like size appear to require handling inside WM_CREATE.

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@msiglreith
Refactor window initialization by splitting NCCREATE and CREATE relat…
c1fc5a3 
…ed tasks.

Fixes issue with invisible owner windows.
@msiglreith msiglreith changed the title Refactor window initialization by splitting NCCREATE and CREATE Windows: Split window initialization across NCCREATE and CREATE Nov 14, 2021
@msiglreith msiglreith added DS - windows C - waiting on maintainer A maintainer must review this code labels Nov 14, 2021
@maroider maroider mentioned this pull request Nov 17, 2021
Closed
maroider
maroider reviewed Nov 17, 2021
View reviewed changes
Copy link
Member

@maroider maroider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be largely sensible, although I'm not entirely sold on having on_nccreate make the call to SetWindowLongPtrW.

Furthermore, I tested it in my brand spanking new Windows 10 VM, and the fix seems to work as advertised :)

src/platform_impl/windows/window.rs Outdated Show resolved Hide resolved
@msiglreith
Copy link
Member Author

Thanks for the review and testing!

I'm not entirely sold on having on_nccreate make the call to SetWindowLongPtrW

I switched it back to storing it in the event callback

@msiglreith @maroider
Update src/platform_impl/windows/event_loop.rs
3d8b300 
Co-authored-by: Markus Røyset <maroider@protonmail.com>
@msiglreith msiglreith merged commit 3ecbea3 into rust-windowing:master Nov 17, 2021
@msiglreith msiglreith deleted the init-refactor branch November 17, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maroider maroider maroider approved these changes

Assignees
No one assigned
Labels
C - waiting on maintainer A maintainer must review this code DS - windows
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows: Parent of owned child window not visible
2 participants
@msiglreith @maroider