Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: support multi-touch #1776

Merged
merged 2 commits into from Nov 28, 2020
Merged

Android: support multi-touch #1776

merged 2 commits into from Nov 28, 2020

Conversation

maxded
Copy link
Contributor

@maxded maxded commented Nov 26, 2020 •
edited

Small PR enabling multi-touch on Android :)

Also rearranged an entry in the changelog as it was added to the top instead of the bottom.

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users

@maxded maxded changed the title Support multi-touch on Android Android: support multi-touch Nov 26, 2020
@msiglreith msiglreith added DS - android C - waiting on maintainer A maintainer must review this code labels Nov 26, 2020
msiglreith
msiglreith reviewed Nov 27, 2020
View reviewed changes
Copy link
Member

@msiglreith msiglreith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

src/platform_impl/android/mod.rs Outdated Show resolved Hide resolved
src/platform_impl/android/mod.rs Outdated Show resolved Hide resolved
@msiglreith msiglreith added C - waiting on author Waiting for a response or another PR and removed C - waiting on maintainer A maintainer must review this code labels Nov 27, 2020
@maxded
Copy link
Contributor Author

maxded commented Nov 28, 2020

Done, should be good to go now!

@msiglreith msiglreith merged commit 5700359 into rust-windowing:master Nov 28, 2020
@MarnixKuijs MarnixKuijs mentioned this pull request Dec 2, 2020
Open
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msiglreith msiglreith msiglreith approved these changes

Assignees
No one assigned
Labels
C - waiting on author Waiting for a response or another PR DS - android
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxded @msiglreith