Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Delayed Message Boxes Fix. #1769

Merged
merged 7 commits into from Nov 24, 2020
Merged

Windows: Delayed Message Boxes Fix. #1769

merged 7 commits into from Nov 24, 2020

Conversation

VZout
Copy link
Contributor

@VZout VZout commented Nov 19, 2020

Message boxes did not appear when opening them. The sound did play but they never were made visible unless the system triggers a redraw (for example when you press alt). The solution to this is to add the default WM_PAINT behavior back in. (DefWindowProc does this if you don't override WM_PAINT)

(This issue appeard in #1615)

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@VZout VZout changed the title Windows: Message Boxes fix. Windows: Delayed Message Boxes Fix. Nov 19, 2020
@VZout VZout marked this pull request as ready for review November 19, 2020 13:30
@msiglreith msiglreith added DS - windows C - waiting on maintainer A maintainer must review this code labels Nov 19, 2020
@msiglreith msiglreith self-requested a review November 19, 2020 15:10
@maroider
Copy link
Member

I ran ahead and tried your changes and it seems this fixes the problem on my machine (latest Win10).
This also seems to fix another problem I observed with message boxes and filed dialogs parented to the Winit window where instead of flashing, the child window would toggle the color of its title bar every time I clicked the Winit window.

@VZout
Copy link
Contributor Author

VZout commented Nov 20, 2020

CI now fails on docs after I updated the changelog...

Seems to be unrelated though: failed to load source for dependency bitflags

Copy link
Member

@msiglreith msiglreith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for looking into this!

src/platform_impl/windows/event_loop.rs Show resolved Hide resolved
@msiglreith msiglreith merged commit 77d5d20 into rust-windowing:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - waiting on maintainer A maintainer must review this code DS - windows
Development

Successfully merging this pull request may close these issues.

None yet

3 participants