key repeat -- how to turn this off?

[Johnrobmiller]

I am speaking of the ElementState module. For example, ElementState::Pressed. The docs only mention "Press" and "Release" and give no further information.

There are many issues opened up requesting this feature dating from years back. I don't think it's worth it for anybody (including myself) to spend, for example, 30 minutes browsing through all of what there is to find on this topic just to get a simple "no" or "yes, here is how it is done."

So, let's keep this discussion simple. How do you turn off key repeat? Let's keep our answers short. This will help us all find out what we need without digging through long threads.

I'll mention this to try and be helpful to other people -- if it is impossible, then it is not too hard just to make a variable such as "was_up_key_press_counter" and reset it to 0 when the key is released. This is only one of many possible workarounds.

EDIT: Going to give some honest feedback, if there truely is no way to detect or turn off key repeat, then I think winit should probably get there stuff together because this is such an obvious and needed feature 😉 It makes me think that the people who made this library have not actually used it to make real programs, or the programs they make are very narrow in type (I am making a game with a custom engine, so that is my perspective), and they don't actually have any idea what their product needs to do to be functional.

[kchibisov]

https://docs.rs/winit/latest/winit/event/struct.KeyEvent.html#structfield.repeat

probably get there stuff

I'd suggest you to learn how to communicate, We don't owe you anything, we're working on it in our free time for nothing. It's not the first time you communicate and try to straight offense people.

[Johnrobmiller]

You think I'm trying to offend, you? I'm trying to help you.

I know you don't owe me anything. I don't owe you anything either, but I actually trying to help you. I am doing free QA for your product. Think about that. If I bring awareness to an issue, as QAers do, then that is valuable, and I am giving that to you for free. Please accept it, because I actually want to see this product get better.

Pointing out genuine problems is NOT being offensive. If you are offended when problems are pointed out to you, then you are a fragile person with a fragile ego, and that is a weakness. You can't get better and grow without humility, and twice now I've seen you lose your temper whenever someone says something negative about you or something you work on, which tells me you might not be a particularly humble person who can integrate criticism and negative feedback into their life. That is far worse then not providing a way to disable key repeat on the winit crate.

But regarding the original post, can it be done? It would be helpful if people could get a straitforward yes or no answer about this.

[madsmtm]

Moderation notice: Comments here are bordering on personal attacks. I would like to remind both parties of the Rust Code of Conduct, to please remain courteous and on topic, and to remember to look past possible language barriers. We are all volunteers, and all want the best for the project!

---

Responding to the actual question about key repeats: No, you cannot turn key repeat off, but you can ignore the event yourself, by only responding to the event if the repeat field is false.

I believe this should yield effectively the same thing, but if there is some reason why that is not true, please try to explain why that is so? Ideally with code, that makes it easier to discuss.

[kchibisov]

You think I'm trying to offend, you? I'm trying to help you.

I pointed you to the field showing you that you can identify that the key is repeat or not so you can ignore them? Like I if you don't understand that from the link I've posted and still try to ask me how it should be done I'm not sure how to help you.

[John-Nagle]

There's a legit question here. I found this because I have a problem where holding an arrow key down for a long time in a game-type program sometimes causes the action to continue for seconds after key release.

I'm ignoring events where input.repeat is set. But I'm not sure that's the correct action. Could that cause me to miss a key-up event?

[madsmtm]

Ignoring events where input.repeat is set is the correct behaviour. I've submitted #3538 to improve the documentation on this, please give your suggestions there!

[John-Nagle]

Hm. I'm getting long delays (seconds) on key-up after a long hold from somewhere. Key-down works fine. This is on Linux/X11. It's almost like all the queued repeats take place and then a key-up is sent.

[kchibisov]

if you render on each key press at may queue if you batch correctly it'll work fine.

[John-Nagle]

I render at AboutToWait only.

[madsmtm]

I render at AboutToWait only.

Which is wrong, you should render inside WindowEvent::RedrawRequested (and probably call window.request_redraw() inside the same).

[John-Nagle]

Sorry, I meant that I render at RedrawRequested, but I call RequestRedraw only at AboutToWait.

Winit docs say to call RequestRedraw at the end of the redraw in RedrawRequested, but that behaves terribly. Worst case is Windows executables under Wine, where every key is delayed about 3 seconds. X11 on Linux is a big sluggish.

Winit doesn't really manage this; it passes the buck to the underlying platform. Wine has its own event loop, and it's not a good one.

[John-Nagle]

That's worst case. Average is around 30FPS, and hasn't been optimized yet.
(Everything except rendering and events is already on another thread.)

[madsmtm]

I've opened #3544 for the slowness on Wine on Windows.

[John-Nagle]

A slightly-related bug/feature: If the frame rate is so slow (< 12 FPS or so) that there is more than one key repeat per frame, and an arrow key is held down for 10 seconds or so, a queue of repeats builds up and the key-up event can be delayed several seconds. Is that intended behavior?

The key repeat rate is kind of high, around 15Hz. Can I set the key repeat rate to 5 HZ or so?

[kchibisov]

The setting is set in your window manager.

Also, 8KHz polling mouse is more of a problem for you if you're that slow.

[John-Nagle]

Found that setting and turned it down.
Yes, it's way too slow. Work on that is in progress.