Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get ready for 0.4 #67

Merged
merged 7 commits into from Jun 5, 2021
Merged

Get ready for 0.4 #67

merged 7 commits into from Jun 5, 2021

Conversation

Lokathor
Copy link
Contributor

@Lokathor Lokathor commented Jan 25, 2021

We've got some breaking changes building up and it's time to move to a 0.4

  • TODO: There's some docs in the related PR from Thomcc that we should incorporate here.
  • TODO: we need to rename ios to uikit and macos to appkit, since you can use the macos types on target_os="ios" (via catalyst) and the ios types on target_os!="ios" (tvos, for example)

@DJMcNab
Copy link

DJMcNab commented Jan 27, 2021

Maybe a better name for TrustedRawWindowHandle would be something like StableRawWindowHandle or similar, since the guarantee is that the inner handle won't be mutated.

@i509VCB
Copy link

i509VCB commented Mar 26, 2021

I'm curious here, I've noticed some of the handles like macOS, Windows, Android and iOS use Option<NonNull<c_void>> while Wayland, XCB and Xlib still use *mut c_void. Is this inconsistency intentional or were those specific handles not changed yet to be in line with the other handles.

@Lokathor
Copy link
Contributor Author

I think it was an accidental oversight.

However, I also think that it's a bad change in retrospect. Every pointer here can optionally be null, that's just a blanket rule. I think actually using Option<NonNull<c_void>> makes things less ergonomic though. Realistically, we'll probably want to undo that change before the next release.

@Friz64 Friz64 mentioned this pull request Jun 2, 2021
@Lokathor
Copy link
Contributor Author

Lokathor commented Jun 5, 2021

Merging this partial progress, and the rest will be finished up in #70

@Lokathor Lokathor merged commit b70fd9f into master Jun 5, 2021
@Lokathor Lokathor deleted the lokathor branch June 5, 2021 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Remove all the cfg guards. Use separate types for each platform New release?
3 participants