Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI warnings #1356

Merged
merged 7 commits into from Jun 22, 2021
Merged

Fix CI warnings #1356

merged 7 commits into from Jun 22, 2021

Conversation

maroider
Copy link
Member

@maroider maroider commented May 21, 2021 •
edited

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users This shouldn't be noticeable for downstream users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

@maroider maroider marked this pull request as draft May 21, 2021 20:52
@maroider maroider marked this pull request as ready for review May 22, 2021 12:17
@maroider maroider mentioned this pull request Jun 16, 2021
Merged
5 tasks
francesca64
francesca64 suggested changes Jun 16, 2021
View reviewed changes
Copy link
Member

@francesca64 francesca64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks great.

glutin/src/lib.rs Outdated Show resolved Hide resolved
francesca64
francesca64 approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@francesca64 francesca64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maroider maroider merged commit 279b5a4 into rust-windowing:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francesca64 francesca64 francesca64 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maroider @francesca64