Use sync_channel to limit the size of job queue?

[lotabout]

rust-threadpool use channel for receiving jobs, that means if the number of jobs is very large it will consume lots of memory.

So I'd like to know if it is a good idea or not to use sync_channel instead of sync.

I googled and found:

• a post that address this issue: https://medium.com/@vsatayamas/limited-job-queue-thread-pool-6e473e6113c8
• and a commit that replace channel with sync_channel: veer66@aa8b157

Not sure why the author hadn't submitted a PR.

[dns2utf8]

Thank you for bringing this to my attention. It influenced the design for 2.0.

[dns2utf8]

Hi you can test it in the 2.0 branch now. If you have feedback, I am happy to listen.
Cheers,
Stefan

[lotabout]

Hi you can test it in the 2.0 branch now. If you have feedback, I am happy to listen. Cheers, Stefan

Play around 2.0's queue_size and it works like a charm.

However I notices that the queue is unbounded by default. Not sure if it's a good idea to put a default limit on it, say num_of_worker * some_default_ratio.