Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit smallvec #9

Open
64 opened this issue Jul 22, 2019 · 2 comments
Open

Audit smallvec #9

64 opened this issue Jul 22, 2019 · 2 comments

Comments

@64
Copy link

64 commented Jul 22, 2019

Over 10k downloads/day and contains a lot of unsafe. Has had a number of vulnerabilities in the past.

@Shnatsel
Copy link
Member

Previous vulns for reference: https://github.com/RustSec/advisory-db/tree/master/crates/smallvec

There are still open concerns about use of uninitialized memory:
servo/rust-smallvec#126
servo/rust-smallvec#139
Porting to MaybeUninit<T> would resolve them.

There is also not much internal consistency checking going on, making the crate hard to test:
servo/rust-smallvec#124

@Shnatsel
Copy link
Member

Shnatsel commented Sep 8, 2019

PR for conversion to MaybeUninit is up: servo/rust-smallvec#162

It will also require bumping the minimum supported Rust version, so a lot of unsafe code present for backwards-compatibility could be cleansed once this lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants