Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-threaded-cf feature produces incompatible API--does not adhere to docs.rust-lang.org guidelines #840

Open
l-monninger opened this issue Dec 2, 2023 · 0 comments

Comments

@l-monninger
Copy link

The multi-threaded-cf feature changes the signature for rocksdb::DB::cf_handle. This is discouraged by docs.rust-lang.org.

Without:

pub fn cf_handle(&self, name: &str) -> Option<&ColumnFamily> {

With:
pub fn cf_handle(&self, name: &str) -> Option<Arc<BoundColumnFamily>> {

I noticed this while try to integrate two third-party workspaces both using cf_handle, i.e., as a consequence of unforeseen feature unification.

@l-monninger l-monninger changed the title multi-threaded-cf features produces incompatible API--does not adhere to dos.rust-lang.org guidelines multi-threaded-cf feature produces incompatible API--does not adhere to dos.rust-lang.org guidelines Dec 2, 2023
@l-monninger l-monninger changed the title multi-threaded-cf feature produces incompatible API--does not adhere to dos.rust-lang.org guidelines multi-threaded-cf feature produces incompatible API--does not adhere to docs.rust-lang.org guidelines Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant