Removed unneeded bindgen features #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some features of bindgen are not needed when building the library and lead to unused dependencies (mainly `clap`). This change deactivates all `bindgen` features except for `runtime` which is required for build to work. This improved debug build time by ~13 seconds and (surprisingly) release build time by ~9 seconds. But perhaps improved security is more interesting.
aleksuss
approved these changes
Jan 19, 2021
SeeSpring
added a commit
to SeeSpring/z3.rs
that referenced
this pull request
Dec 9, 2021
Some features of bindgen are not needed when building the library and lead to unused dependencies (mainly `clap`). This change deactivates all `bindgen` features except for `runtime` which is required for build to work. See also rust-rocksdb/rust-rocksdb#491
sameer
pushed a commit
to prove-rs/z3.rs
that referenced
this pull request
Jan 20, 2022
Some features of bindgen are not needed when building the library and lead to unused dependencies (mainly `clap`). This change deactivates all `bindgen` features except for `runtime` which is required for build to work. See also rust-rocksdb/rust-rocksdb#491
This was referenced Oct 18, 2022
This was referenced Oct 25, 2022
This was referenced Nov 2, 2022
This was referenced Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some features of bindgen are not needed when building the library and
lead to unused dependencies (mainly
clap). This change deactivates allbindgenfeatures except forruntimewhich is required for build towork.
This improved debug build time by ~13 seconds and (surprisingly) release
build time by ~9 seconds. But perhaps improved security is more
interesting.
I can post the outputs from
-Z timingssomewhere if you want, but I don't know where to put it to be accepted and rendered - LMK if you know of a good website. The files have above 200-250k.I intend to backport this into 12.2 after it's accepted.