Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include/rocksdb/env.h #434

Closed
zach-schoenberger opened this issue May 28, 2020 · 5 comments
Closed

include/rocksdb/env.h #434

zach-schoenberger opened this issue May 28, 2020 · 5 comments
Labels
enhancement

Comments

@zach-schoenberger
Copy link

Hi, not sure if this is the proper place for this, but I was wondering if there was any plan to start support for the env.h configs? I ask because I'm looking to use the conifg described here https://github.com/facebook/rocksdb/wiki/Thread-Pool to change the SetBackgroundThreads.
@aleksuss
Copy link
Member

Hello. As far as I can see C API provides all needed stuff to realise this on the Rust side. So I suppose it would be done in the near future. By the way feel free to create PR if you want 🙂

@zach-schoenberger
Copy link
Author

Cool, I had thought about doing that. I just wanted to make sure there wasn't something already in motion or if i missed something since the bindings were already there.

@stanislav-tkach
Copy link
Member

@zach-schoenberger Personally, I wouldn't close the issue to use it for tracking progress, but it's up to you.

@stanislav-tkach
Copy link
Member

I guess this can be closed after #448 is merged.

@stanislav-tkach
Copy link
Member

Closed in #448.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stanislav-tkach @aleksuss @zach-schoenberger