Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add std_rng feature, remove deprecations #948

Merged
merged 6 commits into from Mar 20, 2020
Merged

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Mar 9, 2020

Fixes #938 - CC @matklad.
As a side-effect, std on its own doesn't do that much — ReadRng, one use of HashMap (vs BTreeMap), an implementation of Error.

Also removes a lot of deprecated code.

This test is now redundant with testing within the getrandom repository.
These feature flags are re-exports from getrandom and were
already scheduled for removal in 0.8.
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
- `getrandom` (implied by `std`) is an optional dependency providing the code
behind `rngs::OsRng`
- `std_rng` enables inclusion of `StdRng`, `thread_rng` and `random`
(the latter two *also* require that `std` be enabled)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add std as requirement for std_rng in Cargo.toml?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Perhaps utility is limited, but this still passes:

$ cargo test --no-default-features --features std_rng --tests
...
test rngs::std::test::test_stdrng_construction ... ok
...

@vks
Copy link
Collaborator

vks commented Mar 19, 2020

I think this is ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider hiding StdRng behind a feature flag
3 participants