Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add value-stability tests #888

Merged
merged 11 commits into from Sep 16, 2019
Merged

Add value-stability tests #888

merged 11 commits into from Sep 16, 2019

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Sep 15, 2019

See #786; once this is done for all distrs we can close that.

Currently only for non-deprecated distrs in rand main

@dhardy dhardy requested a review from vks September 15, 2019 11:33
@dhardy
Copy link
Member Author

dhardy commented Sep 15, 2019

Tests pass, except Miri (see rust-lang/miri#950). But I'll address other distributions before merging.

@dhardy
Copy link
Member Author

dhardy commented Sep 15, 2019

The Cauchy test is generating a very slightly different value on OSX and Windows to that on Linux. 😞

Presumably this is because the tan function is provided by system libraries, which have varying degrees of precision. I don't see an alternative to working around this issue. (Maybe someday Rust could have its own implementations of trig/math functions?)

@dhardy
Copy link
Member Author

dhardy commented Sep 16, 2019

The above mentioned issue has been worked around; the only failing test is Miri (unrelated).

@RalfJung
Copy link
Contributor

Miri should be good again now, sorry for that.
Hopefully, we'll get rust-lang/rust#60301 resolved soon-ish, which should avoid such broken Miri components being shipped. But my first attempt at solving that issue just failed spectacularly. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants