Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove #![feature(alloc)] #856

Merged
merged 2 commits into from Aug 23, 2019
Merged

Remove #![feature(alloc)] #856

merged 2 commits into from Aug 23, 2019

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Aug 5, 2019

The alloc crate has been stabilized in 1.36.

@dhardy
Copy link
Member

dhardy commented Aug 6, 2019

Thanks for the PR.

AFAICT this is not a breaking change (except for old nightlies), but will enable support for Rust ≥ 1.36.

Could you please:

  1. Add a note to the MSRV (1.32) testers about this exception
  2. Update the README
  3. Add a note in the CHANGELOG

@RalfJung
Copy link
Contributor

RalfJung commented Aug 8, 2019

The Miri component has been updated, so that part of CI should work again now.

@dhardy
Copy link
Member

dhardy commented Aug 8, 2019

Thanks, I restarted it. But both failures are unrelated to this PR so not worried about them here.

@dhardy
Copy link
Member

dhardy commented Aug 22, 2019

@taiki-e any chance you could make the additions I requested?

@taiki-e
Copy link
Contributor Author

taiki-e commented Aug 22, 2019

@dhardy Sorry for the delay in replying. addressed in 918765d.

@dhardy
Copy link
Member

dhardy commented Aug 23, 2019

Thanks; LGTM

@dhardy dhardy merged commit a4cd495 into rust-random:master Aug 23, 2019
@taiki-e taiki-e deleted the alloc branch August 23, 2019 06:26
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taiki-e @dhardy @RalfJung