Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Bernoulli::new return a Result #803

Merged
merged 1 commit into from May 23, 2019
Merged

Make Bernoulli::new return a Result #803

merged 1 commit into from May 23, 2019

Conversation

vks
Copy link
Collaborator

@vks vks commented May 22, 2019

Fixes #799.

@vks
Copy link
Collaborator Author

vks commented May 22, 2019

I'm not sure whether a breaking change makes sense while deprecating (instead of removing) the other panicking distributions.

dhardy
dhardy approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@dhardy dhardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. As you said before, I don't think this constructor gets called directly too often. We are allowed to make breaking changes in minor releases, and I think this one is worth doing.

I believe it's ready for merging?

@vks
Copy link
Collaborator Author

vks commented May 23, 2019

Yeah, I also think this is ready.

@dhardy dhardy merged commit 7f56d4e into rust-random:master May 23, 2019
@vks vks deleted the bernoulli-no-panic branch May 23, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhardy dhardy dhardy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bernoulli constructor
2 participants
@vks @dhardy