Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise min rustc version to 1.32.0 for version 0.7 #719

Closed
erickt opened this issue Jan 29, 2019 · 9 comments
Closed

raise min rustc version to 1.32.0 for version 0.7 #719

erickt opened this issue Jan 29, 2019 · 9 comments

Comments

@erickt
Copy link
Contributor

erickt commented Jan 29, 2019

Edit: old title: rand does not compile on osx with rust 1.22.0

It looks like the minimum version of rust 1.22.0 no longer works with rand, due to this dependency change in libc: rust-lang/libc#1212. It's using std::mem::size_of as a constant function, but that was stablized in 1.24.0.

edit: forgot to mention I don't personally care about 1.22, so I wouldn't care if you decided to drop support for it.

@dhardy
Copy link
Member

dhardy commented Jan 29, 2019

Interesting; 1.22 still works on Linux at least but sounds like it might be time we update the min version.

I'll leave this open for a while though in case anyone has objections?

@dhardy dhardy changed the title rand does not compile on osx with rust 1.22.0 raise min rustc version to 1.24.0? Jan 29, 2019
@vks
Copy link
Collaborator

vks commented Jan 29, 2019

Looking at libc's Travis config, it seems they officially support Rust 1.13. Is this not true on osx?

@erickt
Copy link
Contributor Author

erickt commented Jan 29, 2019

@vks they do, but the latest version of the libc crate on osx now only supports 1.24.0+ due to using a constant function.

@vks
Copy link
Collaborator

vks commented Jan 29, 2019

Thanks @erickt! I think the best way forward is to wait for a libc fix.

@dhardy
Copy link
Member

dhardy commented Feb 12, 2019

There is another reason we may want to raise the minimum: lazy-static requires 1.24.1 or later.

We don't actually depend on this, but wasm-bindgen does, which is an optional backend for rand_os on WASM. I'm guessing Cargo #1197 is causing my build to include it however (but maybe only because I have wasm targets installed for rustup?). Travis builds on 1.22.0 are still succeeding.

Maybe this isn't sufficient reason to require a later compiler, however?

@dhardy
Copy link
Member

dhardy commented Feb 26, 2019

According to initial feedback on reddit, 1.24.1 is pretty-much the oldest anyone cares about, and most (or all) are happy to use the latest stable release (at least for applications).

This makes me happier about bumping the minimum to 1.28, which we might want for rust-random/getrandom#3.

@dhardy dhardy changed the title raise min rustc version to 1.24.0? raise min rustc version to 1.28.0 for version 0.7 Mar 1, 2019
@dhardy
Copy link
Member

dhardy commented Mar 1, 2019

FYI, we will likely raise the minimum rustc version to 1.28 for version 0.7 of Rand.

I'll leave this open in the mean-time as a place to raise objections, if necessary (so far I have seen only one minor concern).

@newpavlov
Copy link
Member

BTW how about going all the way down and migrate to 2018 edition? 1.28 is only two releases behind, so it may be worth considering.

@dhardy
Copy link
Member

dhardy commented Mar 23, 2019

FYI we are increasing the MSRV for getrandom to 1.32.0. This will become a dependency of rand v0.7, so rustc 1.32 will be required.

However, we will try to avoid depending on this compiler version in rand directly just yet, so that if significant issues come up there shouldn't be too much of an issue reverting this.

@dhardy dhardy changed the title raise min rustc version to 1.28.0 for version 0.7 raise min rustc version to 1.32.0 for version 0.7 Mar 23, 2019
This was referenced Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants