Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable i128 and u128 on emscripten (fixes #669) #671

Merged
merged 2 commits into from
Dec 30, 2018
Merged

Disable i128 and u128 on emscripten (fixes #669) #671

merged 2 commits into from
Dec 30, 2018

Conversation

svenstaro
Copy link
Contributor

This was also reported as #669, koute/cargo-web#152 and emscripten-core/emscripten-fastcomp#169.

Basically emscripten can't properly deal with i128 and u128. This should be fixed in emscripten upstream but it's unlikely to happen. This is the best we can do. This also changes the .travis-ci.yml so that this problem doesn't re-occur without getting caught.

@svenstaro
Copy link
Contributor Author

The failure seems unrelated to my changes.

@svenstaro
Copy link
Contributor Author

svenstaro commented Dec 25, 2018

You can get this building by clearing the cache.

@dhardy
Copy link
Member

dhardy commented Dec 29, 2018

I tried clearing the cache (twice now I think). No luck there.

@svenstaro
Copy link
Contributor Author

I fixed it @dhardy

@dhardy dhardy merged commit 158c3e9 into rust-random:master Dec 30, 2018
@svenstaro
Copy link
Contributor Author

Could you make a release with this included?

@svenstaro svenstaro deleted the fix-emscripten-target branch January 2, 2019 03:57
@dhardy
Copy link
Member

dhardy commented Jan 6, 2019

@svenstaro why are my builds now all failing with this?

$ EMCC_CFLAGS="-s ERROR_ON_UNDEFINED_SYMBOLS=0" cargo web test --target wasm32-unknown-emscripten --no-run
Downloading emscripten-1.38.19-1-x86_64-unknown-linux-gnu.tgz...
2.73 MB / 201.71 MB [>----------------------------

@svenstaro
Copy link
Contributor Author

@dhardy taking a look.

@svenstaro
Copy link
Contributor Author

That's really weird though, isn't it? Pull requests work, your master branch builds do not.

@svenstaro
Copy link
Contributor Author

The only thing that's different at this step between PRs and master is secrets, env vars, and the cache key as far as I know. I can't see your secrets and env vars but can you check those and see whether there's anything weird? Also, could you try clearing cache?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants