Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename rand_hc128 crate to rand_hc #636

Merged
merged 1 commit into from Oct 30, 2018
Merged

Rename rand_hc128 crate to rand_hc #636

merged 1 commit into from Oct 30, 2018

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Oct 29, 2018

Closes #617

I'll yank rand_hc128 after.

@dhardy dhardy requested a review from vks October 29, 2018 09:38
vks
vks approved these changes Oct 29, 2018
View reviewed changes
Copy link
Collaborator

@vks vks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do we want to rename Hc128Rng to Hc128?

@dhardy
Copy link
Member Author

dhardy commented Oct 29, 2018

I think not. See @burdges last comment there. It's also unnecessarily short.

@vks
Copy link
Collaborator

vks commented Oct 29, 2018

Fair enough, let's merge it then.

@dhardy dhardy merged commit d9a960f into rust-random:master Oct 30, 2018
@dhardy dhardy deleted the move-hc branch October 30, 2018 09:52
@dhardy
Copy link
Member Author

dhardy commented Oct 30, 2018

Yanked and published

@atoav atoav mentioned this pull request Nov 1, 2018
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vks vks vks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhardy @vks