Update wasm-bindgen rand bindings #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the node/browser detection and additionally flag that the wasm-bindgen feature not no longer requires nightly!
|
Thanks @alexcrichton. I can't fully review this code but coming from you I can take it on trust. BTW any idea whether we can have better CI tests for the web? |
|
We're working on better CI! We've got an experimental crate for this currently, although it's still a little unstable to use but once that's stabilized it should be sufficient for running tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the node/browser detection and additionally flag that the
wasm-bindgen feature not no longer requires nightly!