Mention that Fill supports floats
#1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhardy
reviewed
Sep 16, 2021
| @@ -158,7 +158,7 @@ use crate::Rng; | |||
| /// * Tuples (up to 12 elements): each element is generated sequentially. | |||
| /// * Arrays (up to 32 elements): each element is generated sequentially; | |||
| /// see also [`Rng::fill`] which supports arbitrary array length for integer | |||
| /// types and tends to be faster for `u32` and smaller types. | |||
| /// and float types and tends to be faster for `u32` and smaller types. | |||
There was a problem hiding this comment.
This is a little ambiguous: where exactly is fill faster and where does it produce different results? This doc was written before fill supported floats (for AsBytesMut trait IIRC).
There was a problem hiding this comment.
Fair enough, this should be verified in benchmarks as well.
There was a problem hiding this comment.
@vks we have benches:
$ cargo +nightly bench --bench misc gen_1kb
running 8 tests
test gen_1kb_u16_fill ... bench: 137 ns/iter (+/- 0) = 7474 MB/s
test gen_1kb_u16_gen_array ... bench: 445 ns/iter (+/- 2) = 2301 MB/s
test gen_1kb_u16_iter_repeat ... bench: 485 ns/iter (+/- 0) = 2111 MB/s
test gen_1kb_u16_sample_iter ... bench: 660 ns/iter (+/- 2) = 1551 MB/s
test gen_1kb_u64_fill ... bench: 128 ns/iter (+/- 2) = 8000 MB/s
test gen_1kb_u64_gen_array ... bench: 146 ns/iter (+/- 0) = 7013 MB/s
test gen_1kb_u64_iter_repeat ... bench: 123 ns/iter (+/- 0) = 8325 MB/s
test gen_1kb_u64_sample_iter ... bench: 150 ns/iter (+/- 1) = 6826 MB/s
test result: ok. 0 passed; 0 failed; 0 ignored; 8 measured; 6 filtered out; finished in 8.52s
dhardy
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #269.