Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing trait implementations #1126

Merged
merged 6 commits into from May 14, 2021
Merged

Add missing trait implementations #1126

merged 6 commits into from May 14, 2021

Conversation

vks
Copy link
Collaborator

@vks vks commented May 13, 2021

Adds implementations of Copy, Clone, PartialEq, Eq, Error and Display for distributions and their error types where appropriate, improving consistency.

Fixes #1125.

Copy link
Member

@dhardy dhardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vks
Copy link
Collaborator Author

vks commented May 14, 2021

Thanks for the review!

@vks vks merged commit 36234a5 into rust-random:master May 14, 2021
@vks vks deleted the missing-copy branch May 14, 2021 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Copy implementations
2 participants