Initial implementation of Slice distribution #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking through the |
|
It seems the newly added tests don't compile. |
|
Sorry about that, fixed |
vks
reviewed
Mar 29, 2021
vks
reviewed
Mar 29, 2021
- Replace Option<Self> with Result<Self, EmptySlice> - Add a debug_assert to the unsafe part of the code
dhardy
reviewed
Mar 31, 2021
kazcw
requested changes
May 12, 2021
|
@kazcw Well spotted, thanks! |
kazcw
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new
Slicedistribution which uniformly samples items from a slice.Fixes #1105