Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rand v0.8, rand_distr v0.4 #1076

Merged
merged 4 commits into from Dec 18, 2020
Merged

Rand v0.8, rand_distr v0.4 #1076

merged 4 commits into from Dec 18, 2020

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Dec 14, 2020

Slated for the end of the week. I think we can go ahead with this?

@newpavlov @josephlr how is getrandom v0.2.1 progressing? I guess you are waiting for CI fixes too.

To check:

@newpavlov
Copy link
Member

how is getrandom v0.2.1 progressing? I guess you are waiting for CI fixes too.

I think we can release it after merging rust-random/getrandom#177 and rust-random/getrandom#178, but I can not merge PRs without at least one review. We also need to migrate CI to GitHub Actions. I can do the Windows/Linux/MacOS/docs part, but I am not confident enough about WASM and cross-platform parts. I guess, we can add the latter ones in a separate PR a bit later.

@dhardy
Copy link
Member Author

dhardy commented Dec 14, 2020

I think you can mostly copy the Rand CI config. A cross case is already included, but not WASM. Maybe @josephlr can help with that.

@dhardy
Copy link
Member Author

dhardy commented Dec 18, 2020

I updated the changelog (quite a bit was missing).

We're still missing the note regarding stdweb and winxp deprecation in the update guide (book#28). Shall we wait on that before publishing?

@newpavlov
Copy link
Member

newpavlov commented Dec 18, 2020

@dhardy
I can do a release today, if you'll approve the PRs.

@dhardy
Copy link
Member Author

dhardy commented Dec 18, 2020

@newpavlov I'd prefer not to: (1) I passed maintenance over to @josephlr and (2) it doesn't actually matter if the Rand release is ahead of getrandom v0.2.1 provided we mention this in the book. I'm waiting on @vks to update the book, but I guess I can if he can't.

@dhardy
Copy link
Member Author

dhardy commented Dec 18, 2020

I think that's the third time sudo apt install gcc-multilib has failed today.

@newpavlov
Copy link
Member

Add apt-get update before the install command as I did here.

@dhardy dhardy merged commit 98a1aaf into rust-random:master Dec 18, 2020
@dhardy
Copy link
Member Author

dhardy commented Dec 18, 2020

rand v0.8 is live, seems I can't publish rand_distr v0.4 now.

@josephlr
Copy link
Member

josephlr commented Jan 4, 2021

getrandom v0.2.1 is live (with all the changes @newpavlov mentioned above). I also have rust-random/getrandom#192 which adds some more CI stuff (for wasm/wasi).

Sorry for the delay in reviewing over the holidays!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants