From 39a312c1a3980c9939d05b55f1429f76755e4027 Mon Sep 17 00:00:00 2001 From: Ralf Jung Date: Sat, 20 Apr 2019 18:29:17 +0200 Subject: [PATCH] apply review feedback --- src/distributions/gamma.rs | 3 --- src/distributions/poisson.rs | 14 +++++--------- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/src/distributions/gamma.rs b/src/distributions/gamma.rs index 26568924ef9..90f07cedfae 100644 --- a/src/distributions/gamma.rs +++ b/src/distributions/gamma.rs @@ -304,9 +304,6 @@ mod test { use distributions::Distribution; use super::{Beta, ChiSquared, StudentT, FisherF}; - #[cfg(not(miri))] // Miri is too slow - const N: u32 = 1000; - #[cfg(miri)] const N: u32 = 100; #[test] diff --git a/src/distributions/poisson.rs b/src/distributions/poisson.rs index 48b0d6c4f46..22b7e76baa8 100644 --- a/src/distributions/poisson.rs +++ b/src/distributions/poisson.rs @@ -108,20 +108,16 @@ mod test { use distributions::Distribution; use super::Poisson; - #[cfg(not(miri))] // Miri is too slow - const N: u32 = 1000; - #[cfg(miri)] - const N: u32 = 100; - #[test] + #[cfg(not(miri))] // Miri is too slow fn test_poisson_10() { let poisson = Poisson::new(10.0); let mut rng = ::test::rng(123); let mut sum = 0; - for _ in 0..N { + for _ in 0..1000 { sum += poisson.sample(&mut rng); } - let avg = (sum as f64) / (N as f64); + let avg = (sum as f64) / 1000.0; println!("Poisson average: {}", avg); assert!((avg - 10.0).abs() < 0.5); // not 100% certain, but probable enough } @@ -133,10 +129,10 @@ mod test { let poisson = Poisson::new(15.0); let mut rng = ::test::rng(123); let mut sum = 0; - for _ in 0..N { + for _ in 0..1000 { sum += poisson.sample(&mut rng); } - let avg = (sum as f64) / (N as f64); + let avg = (sum as f64) / 1000.0; println!("Poisson average: {}", avg); assert!((avg - 15.0).abs() < 0.5); // not 100% certain, but probable enough }