Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only impl std traits if feature is specified #106

Merged
merged 3 commits into from
Sep 20, 2019
Merged

Conversation

josephlr
Copy link
Member

This is a breaking change for #98, so it's being merged against the 0.2 branch.

See #94 and #96 for context on this change.

@josephlr josephlr merged commit 689771b into rust-random:0.2 Sep 20, 2019
@josephlr josephlr deleted the std branch September 20, 2019 01:52
@dhardy
Copy link
Member

dhardy commented Sep 20, 2019

I foresee an issue here: rand_core has optional dependencies on getrandom and std, and now needs to depend on getrandom/std only if both are enabled. I'm not sure how to do that. See here where the same issue came up recently.

josephlr added a commit to josephlr/getrandom that referenced this pull request Sep 21, 2019
* Fix CI to allow for PRs against 0.2 to be run

* Only impl std traits if feature is specified

* Fix l4re
josephlr added a commit to josephlr/getrandom that referenced this pull request Sep 24, 2019
* Fix CI to allow for PRs against 0.2 to be run

* Only impl std traits if feature is specified

* Fix l4re
josephlr added a commit that referenced this pull request Oct 16, 2019
* Fix CI to allow for PRs against 0.2 to be run

* Only impl std traits if feature is specified

* Fix l4re
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants