New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace ansi_term with yansi #102
Conversation
Thank you very much for taking this on and fixing it!
Agree that this is unlikely to break anything, I'm happy to include it in a minor patch version and cover it with a note in the changelog. I also think having a re-exported member is not required here, so I suggest we remove it altogether rather than have this problem again in the future. I've pushed several commits to the branch, if you could take a look and give me your opinion on them:
If you're happy with this review points, I'm happy to squash into a new release. |
It also appears that |
Opened SergioBenitez/yansi#38, - yansi MSRV appears to be 1.54.0, which I'm happy to bump to as it's more than a year old at this point. |
Your additions look fine to me |
Thanks for taking a look. This is currently blocked on needing some more repo permissions - I have reached out to the owner to resolve this. |
@colin-kiegel maybe giving others merge rights for the future? |
Released in 1.3.0 |
Fixes #101
Technically a breaking change because
ansi_term::Style
is publicly-exported (due to the way the macros are constructed), but I would be very surprised if anyone was relying on it.