Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No package.metadata.bootloader.target key found in Cargo.toml of bootloader #195

Closed
jamesmarva opened this issue Aug 22, 2021 · 9 comments
Closed

Comments

@jamesmarva
Copy link

I add the code below in Cargo.toml

[package.metadata.bootloader]
target="fledgeos.json"

but it still happen the error

Caused by:
    The `bootloader` dependency has not the right format: No `package.metadata.bootloader.target` key found in Cargo.toml of
bootloader
@jamesmarva
Copy link
Author

I use bootloader 0.10.6

[package]
name = "fledgeos-1"
version = "0.1.0"
edition = "2018"

[dependencies]
bootloader = "0.10.6"
x86_64 = "0.14.3"

[package.metadata.bootimage]
run-command = ["qemu-system-x86_64.exe", "-drive", "format=raw,file=F:/Rust-In-Action/ch11/fledgeos-1/target/fledge/debug/bootimage-fledgeos-1.bin"]

[package.metadata.bootloader]
target="fledgeos.json"

@bjorn3
Copy link
Contributor

bjorn3 commented Aug 22, 2021

Are you following https://os.phil-opp.com? If so you need to use bootloader 0.9 and not 0.10.

@Nicceboy
Copy link

It seems that bootimage is requiring this entry, and it was removed in 610255e. It works with lower version, but was this change intentional? It was originally added to maintain compatibility based on this commit 33b8ce6. What if I want to use later version of bootloader with bootimage?

@vikigenius
Copy link

Yeah, this is problematic I wanted to use 0.10 version to remove the deprecation warnings for llvm_asm! but it doesn't work due to this issue. Any clarification so as to why the entry was removed would be welcome

@bjorn3
Copy link
Contributor

bjorn3 commented Oct 31, 2021

Bootloader 0.10 works in a fundamentally different way to add support for uefi. It for example it doesn't use bootimage at all. Doesn't the latest release in the 0.9 series work without llvm_asm? Does cargo update work?

@vikigenius
Copy link

vikigenius commented Oct 31, 2021

@bjorn3 Nope, even with Cargo update the warning is still there. And it is using the latest version in the 0.9 series: 0.9.19, I checked.

@calebschoepp
Copy link

@vikigenius Did you ever manage to get rid of the llvm_asm! warnings?

@vikigenius
Copy link

Nope, but I did manage to get the latest version of bootloader working following instructions in the crate documentation.

@phil-opp
Copy link
Member

phil-opp commented Jan 9, 2022

With #204, I think we can now close this.

@phil-opp phil-opp closed this as completed Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants