Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Element trait #143

Merged
merged 2 commits into from Jul 16, 2020
Merged

Refactor Element trait #143

merged 2 commits into from Jul 16, 2020

Conversation

kngwyu
Copy link
Member

@kngwyu kngwyu commented Jul 15, 2020 •
edited

I hope this to be the last step to 0.10.0.
TypeNum trait is refactored as Element, and PyArray<PyObject> is allowed again.

@kngwyu kngwyu force-pushed the element branch 2 times, most recently from b3f37a7 to 29cedec Compare July 15, 2020 15:27
@kngwyu kngwyu changed the title Refactor Element trait and allow PyArray<PyObject> Refactor Element trait Jul 15, 2020
@kngwyu
Copy link
Member Author

kngwyu commented Jul 15, 2020

At last, I gave up PyArray<PyObject> because of a weird segfault in Py_FinalizeEx.
I'll debug this later after releasing 0.10.

@kngwyu kngwyu merged commit 2edf1f3 into PyO3:master Jul 16, 2020
@kngwyu kngwyu mentioned this pull request Jul 12, 2021
Closed
@messense messense mentioned this pull request Jul 12, 2021
Closed
@TimAWescott TimAWescott mentioned this pull request Sep 21, 2021
Closed
@adamreichold adamreichold mentioned this pull request Nov 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kngwyu