Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bound FloatCore by Bounded? #55

Closed
kvark opened this issue Mar 19, 2018 · 1 comment
Closed

Bound FloatCore by Bounded? #55

kvark opened this issue Mar 19, 2018 · 1 comment
Labels
breaking change postponed

Comments

@kvark
Copy link

kvark commented Mar 19, 2018

Both traits are in this crate, and it seems highly redundant to me to have min_value() and max_value() duplicated between FloatCore and Bounded. Any objections to just having trait FloatCore: Bounded?
@cuviper cuviper mentioned this issue Mar 19, 2018
Open
@cuviper
Copy link
Member

cuviper commented Mar 19, 2018

I suppose it could, but it would be a breaking change now. I've added this to #47, at least.

@cuviper cuviper closed this as completed Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change postponed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cuviper @kvark