Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default epsilon implementation for Float #4

Closed
cuviper opened this issue Dec 19, 2017 · 1 comment
Closed

Remove default epsilon implementation for Float #4

cuviper opened this issue Dec 19, 2017 · 1 comment

Comments

@cuviper
Copy link
Member

cuviper commented Dec 19, 2017

From @AtheMathmo on September 22, 2016 19:57

With #231 we introduced a new epsilon() function which returns the EPSILON constant for f32 and f64. In order to prevent breaking the API we provided a default implementation here - using NumCast to return f32::EPSILON.

When we are ready to release breaking changes we should consider removing this default implementation.

Copied from original issue: rust-num/num#232

@cuviper
Copy link
Member Author

cuviper commented Mar 5, 2018

I've decided to limit the clutter of breaking change issues, so they will now be tracked collectively in #47. I'm closing this issue for now as postponed but we can still discuss its merits here as needed.

@cuviper cuviper closed this as completed Mar 5, 2018
@cuviper cuviper removed this from the num-traits-0.x milestone Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant