Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for euclidean division and modulation #159

Closed
zesterer opened this issue Apr 9, 2020 · 0 comments · Fixed by #195
Closed

Add support for euclidean division and modulation #159

zesterer opened this issue Apr 9, 2020 · 0 comments · Fixed by #195
Labels
enhancement

Comments

@zesterer
Copy link

zesterer commented Apr 9, 2020

Support for div_euclid and rem_euclid would be very useful, particularly for vek: yoanlcq/vek#11.
@cuviper cuviper mentioned this issue Apr 16, 2020
Closed
@SparrowLii SparrowLii mentioned this issue Nov 13, 2020
Merged
@khyperia khyperia mentioned this issue Mar 1, 2021
Merged
bors bot added a commit that referenced this issue Apr 30, 2022
@bors @SparrowLii @cuviper
Merge #195
4cd097c 
195: Add support for euclidean division and modulation r=cuviper a=SparrowLii

Fixes #159 
Add support for euclidean division and modulation. 

Co-authored-by: SparrowLii <liyuancylx@gmail.com>
Co-authored-by: SparrowLii <liyuan179@huawei.com>
Co-authored-by: Josh Stone <cuviper@gmail.com>
@bors bors bot closed this as completed in #195 Apr 30, 2022
@jaybosamiya jaybosamiya mentioned this issue Jul 16, 2022
Merged
bors bot added a commit to rust-num/num-bigint that referenced this issue Aug 22, 2023
@bors @jaybosamiya @cuviper
Merge #245
c133d4e 
245: Implement Euclid division and remainder r=cuviper a=jaybosamiya

Now that a common trait for this has been sorted out (rust-num/num-traits#159 implemented and merged in rust-num/num-traits#195), we can now close #146 by implementing the trait for `BigInt`s. This commit does just that.

Co-authored-by: Jay Bosamiya <jaybosamiya@gmail.com>
Co-authored-by: Josh Stone <cuviper@gmail.com>
bors bot added a commit to rust-num/num-bigint that referenced this issue Aug 22, 2023
@bors @jaybosamiya @cuviper
Merge #245
27e4acf 
245: Implement Euclid division and remainder r=cuviper a=jaybosamiya

Now that a common trait for this has been sorted out (rust-num/num-traits#159 implemented and merged in rust-num/num-traits#195), we can now close #146 by implementing the trait for `BigInt`s. This commit does just that.

Co-authored-by: Jay Bosamiya <jaybosamiya@gmail.com>
Co-authored-by: Josh Stone <cuviper@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for euclidean division and modulation SparrowLii/num-traits
2 participants
@cuviper @zesterer