Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency of macros use #50

Open
maxbla opened this issue Jun 14, 2019 · 1 comment
Open

Consistency of macros use #50

maxbla opened this issue Jun 14, 2019 · 1 comment

Comments

@maxbla
Copy link
Contributor

maxbla commented Jun 14, 2019

Add, Sub and Rem are implemented with macros. They're harder to read because of it, but their implementations are all the same except one line. Separately, AddAssign, SubAssign and RemAssign are implemented without macros, and their implementations are all the same except one line.

We should consider going full macro or going full no-macro for all of these.

@cuviper
Copy link
Member

cuviper commented Jun 26, 2019

I think the macros are definitely good for forwarding all the by-ref/value stuff, but I think it would be fine to separate the actual Add/Sub/Rem implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants