Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct documentation for gcd #50

Merged
merged 1 commit into from Mar 21, 2022
Merged

Correct documentation for gcd #50

merged 1 commit into from Mar 21, 2022

Conversation

ciphergoth
Copy link
Contributor

gcd asserts that the result is "always positive", but the result is (correctly) zero if both parameters are zero, so replace "positive" with "non-negative".

(Zero is correct here because 0Z + 0Z = 0Z where Z is the integers)

`gcd` asserts that the result is "always positive", but the result is (correctly) zero if both parameters are zero, so replace "positive" with "non-negative".

(Zero is correct here because 0Z + 0Z = 0Z where Z is the integers)
@cuviper
Copy link
Member

cuviper commented Mar 21, 2022

Thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 21, 2022

@bors bors bot merged commit 7a8397f into rust-num:master Mar 21, 2022
@ciphergoth ciphergoth deleted the patch-1 branch March 22, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants