Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Mul/Div/RemAssign directly #75

Merged
merged 1 commit into from Jan 23, 2020
Merged

Implement Mul/Div/RemAssign directly #75

merged 1 commit into from Jan 23, 2020

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jan 23, 2020

We can avoid a self.clone() by using more op-assign calls in place.

Fixes #50.

@cuviper
Implement Mul/Div/RemAssign directly
77e77f0 
We can avoid a `self.clone()` by using more op-assign calls in place.

Fixes rust-num#50.
@cuviper
Copy link
Member Author

cuviper commented Jan 23, 2020

bors r+

bors bot added a commit that referenced this pull request Jan 23, 2020
@bors @cuviper
Merge #75
7fb4f1c 
75: Implement Mul/Div/RemAssign directly r=cuviper a=cuviper

We can avoid a `self.clone()` by using more op-assign calls in place.

Fixes #50.

Co-authored-by: Josh Stone <cuviper@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 23, 2020

Build succeeded

@bors bors bot merged commit 77e77f0 into rust-num:master Jan 23, 2020
@cuviper cuviper deleted the direct-assign branch February 6, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve MulAssign and DivAssign
1 participant
@cuviper