Add DoubleEndedIterator to U32Digits and U64Digits
#208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did you explore what it would take to add that implementation instead? |
|
I'd thought about it a little but went with this instead -- doing a quick mockup, it looks like that won't be as difficult as I first thought, so I'll give it a go. |
|
It's definitely a lot cleaner than I expected; I think we should go that route instead. |
PatrickNorton
changed the title
DoubleEndedIterator to U32Digits and U64Digits
|
@cuviper Thoughts on the new implementation? |
|
It looks good to me, thanks! bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 27, 2021
208: Add `DoubleEndedIterator` to `U32Digits` and `U64Digits` r=cuviper a=PatrickNorton Since `U32Digits` and `U64Digits` do not implement `DoubleEndedIterator`, there is currently no easy way to iterate over the digits in a big-ended fashion. Co-authored-by: Patrick Norton <patrick.147.norton@gmail.com>
|
Build failed: |
|
Hmm, that failure with |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
U32DigitsandU64Digitsdo not implementDoubleEndedIterator, there is currently no easy way to iterate over the digits in a big-ended fashion.