rust: use explicitily Integer::div_ceil #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it then be possible to cherry-pick this for the version 0.3 as well ? |
cuviper
requested changes
Sep 3, 2021
|
I'll go ahead with those changes myself, because a lot of folks are hitting CI breakage from this. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 3, 2021
219: rust: use explicitily Integer::div_ceil r=cuviper a=catenacyber Fixes #218 cf rust-lang/rust#88581 Co-authored-by: Philippe Antoine <contact@catenacyber.fr> Co-authored-by: Josh Stone <cuviper@gmail.com>
|
Build failed: |
|
bors r+ |
|
bors retry |
|
Thanks for getting this :-) |
qti3e
added a commit
to qti3e/candid
that referenced
this pull request
Sep 7, 2021
The compilation is broken on nightly, due to: rust-lang/rust#88581 This commit upgrades the num-bigint package to v0.4.2 which resolves this issue: rust-num/num-bigint#219
This was referenced Sep 7, 2021
chenyan-dfinity
pushed a commit
to dfinity/candid
that referenced
this pull request
Sep 7, 2021
The compilation is broken on nightly, due to: rust-lang/rust#88581 This commit upgrades the num-bigint package to v0.4.2 which resolves this issue: rust-num/num-bigint#219
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #218
cf rust-lang/rust#88581