Fix a few inconsistencies around negative strides in constructors #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluss
changed the title
|
This is sort of a follow-up to #885 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ArrayView from_shape constructors that allow and have a natural interpretation for the array head pointer, now support negative strides properly.
Note that the raw view and raw pointer constructors for regular views don't support negative strides yet. There are assertions to check this. The goal of this PR is to have consistency for the next release, not to add new features for negative strides.
The first commit is by @SparrowLii (some changes dropped from that commit) from PR #901.
Closes #942