Update ndarray-rand to rand 0.8 #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bluss
commented
Dec 21, 2020
bluss
commented
- Update rand/rand_distr
- Also fix unintentional restrictions on the sample methods (now they can be used with views)
Also edit docs and links in docs. Remove some instances of versioned links (we can't have too many places where we need to update the version for each new version of rand). Update ndarray-rand quickcheck after rand update (quickcheck is still on rand 0.7, but the rest of the crate uses rand 0.8) Update numeric-tests to rand 0.8
The RandomExt methods for sampling were unintentionally restricted to owned arrays only (like the original random constructors). Now the methods which can also apply to array views.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.