Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set CLOEXEC on Fuchsia #443

Open
ttttcrngyblflpp opened this issue May 30, 2023 · 2 comments
Open

Don't set CLOEXEC on Fuchsia #443

ttttcrngyblflpp opened this issue May 30, 2023 · 2 comments

Comments

@ttttcrngyblflpp
Copy link

The CLOEXEC flag is currently set for the Fuchsia platform, e.g. in accept.

Even though the flag is supported on Fuchsia, the flag doesn't do anything because Fuchsia doesn't really have exec as a concept. As a result, it would seem wise to pretend that this flag doesn't exist on Fuchsia.

@Thomasdezeeuw
Copy link
Collaborator

I don't know enough about Fuchsia to say whether or not this makes sense, @tamird any thoughts?

@tamird
Copy link
Contributor

tamird commented May 31, 2023

Everything @ttttcrngyblflpp says is correct. The flag is supported - it can be set and queried - but doesn't do anything because exec doesn't exist in Fuchsia by design.

Whether or not this justifies conditional logic is less clear to me.

There's an issue tracking this in Fuchsia, which may be useful to cite when making changes in this area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants