Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download progress swamps terminal on MinGW #76

Closed
alexcrichton opened this issue Feb 25, 2016 · 3 comments
Closed

Download progress swamps terminal on MinGW #76

alexcrichton opened this issue Feb 25, 2016 · 3 comments

Comments

@alexcrichton
Copy link
Member

In a MinGW terminal I ran multirust update, and the new download progress counters look like they didn't correctly overwrite themselves so the output was just swamped with updates:

https://i.imgur.com/dBVSCGV.png

@crumblingstatue
Copy link
Contributor

Related to #71 .

I'm not sure what's going on here. StdoutTerminal::carriage_return() should take care of resetting the cursor position to the beginning of the line, unless I'm either misinterpreting its function, or it's not working correctly on mingw terminals.

This should be less severe once #80 gets merged, as the information is printed only once per second. It would still be desirable for the line overwriting to work properly on mingw terminals though.

If someone has a mingw terminal and some time, investigating this would be appreciated.

Maybe we should use a different crate that provides proper functionality for writing to arbitrary locations in the terminal. I'm not aware of any complete cross-platform solutions to this, however.

@brson
Copy link
Contributor

brson commented Apr 1, 2016

I believe this is fixed?

@Diggsey
Copy link
Contributor

Diggsey commented May 8, 2016

Yup, although until Stebalien/term#58 is fixed, there's no download progress at all.

@Diggsey Diggsey closed this as completed May 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants