Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift away from term crate #1818

Closed
kinnison opened this issue Apr 29, 2019 · 12 comments · Fixed by #3351
Closed

Shift away from term crate #1818

kinnison opened this issue Apr 29, 2019 · 12 comments · Fixed by #3351

Comments

@kinnison
Copy link
Contributor

The term crate is unmaintained. cf. Stebalien/term#93

It is recommended we shift to termcolor (https://crates.io/crates/termcolor)

Whatever the move is toward, it ought to be away from an unmaintained and troublesome crate.

@kinnison
Copy link
Contributor Author

Doing this may solve #1800

@jens1o
Copy link

jens1o commented Apr 30, 2019

I'd like to take this. :)

@kinnison
Copy link
Contributor Author

@jens1o Cool, thank you, if you want to discuss things, you should come onto the Rustup discord on https://discord.gg/cKdYFVz and we can talk.

rbtcollins added a commit to rbtcollins/rustup.rs that referenced this issue May 5, 2019
To avoid a dependency on the cli crate, move term2 to the root.

It could go into misc, but I figure I'll let whomever works on
bug rust-lang#1818 do any and all fine tuning needed; at least having Everything
consolidated should make that work easier.
rbtcollins added a commit to rbtcollins/rustup.rs that referenced this issue May 5, 2019
To avoid a dependency on the cli crate, move term2 to the root.

It could go into misc, but I figure I'll let whomever works on
bug rust-lang#1818 do any and all fine tuning needed; at least having Everything
consolidated should make that work easier.
@omang777
Copy link

I like this.

@pickfire
Copy link
Contributor

pickfire commented Oct 2, 2019

I believe this is solved?

@kinnison
Copy link
Contributor Author

kinnison commented Oct 2, 2019

I believe this is solved?

@pickfire At this time we're still using term because we had issues with other options

@Rudi3
Copy link
Contributor

Rudi3 commented Oct 8, 2019

I'm not sure what exactly you need, but what about https://github.com/crossterm-rs/crossterm?

@kinnison
Copy link
Contributor Author

kinnison commented Oct 8, 2019

That looks potentially good, though I was thinking more about a crate which integrates progress bars and messages.

@Rudi3
Copy link
Contributor

Rudi3 commented Oct 8, 2019

I see, what about https://github.com/mitsuhiko/indicatif then?

@kinnison
Copy link
Contributor Author

kinnison commented Oct 8, 2019

Yeah something like Indicatif would be good. It'll be quite a bit of work to rearrange all the output to go properly via that, but it would potentially allow some cleanup.

@aloucks
Copy link
Contributor

aloucks commented Aug 18, 2020

What was the issue with termcolor? Isn't that what cargo uses?

@kinnison
Copy link
Contributor Author

I don't recall what prevented termcolor from being suitable, likely something to do with how we currently (hackily) do progress bars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants