Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint for accessing the shas of unrolled PR builds #1427

Open
rylev opened this issue Aug 26, 2022 · 1 comment
Open

Add endpoint for accessing the shas of unrolled PR builds #1427

rylev opened this issue Aug 26, 2022 · 1 comment

Comments

@rylev
Copy link
Member

rylev commented Aug 26, 2022

We now have support for unrolling a rollup and building artifacts for them. The shas identifying these artifacts are then posted to GitHub, but they are not stored anywhere else. It would be nice to expose and endpoint that allows others to ask for this information.

We could do this by adding a database table which stores the mapping of PR to sha. However, since creating the sha should be reproducible, it might be possible to do this on demand.

One additional note, since these builds have proved useful for more than just perf (e.g., for catching regressions), it feels a bit weird that this lives in rustc-perf. I'm not sure where else this should go though.

@Mark-Simulacrum
Copy link
Member

We could move the code to triagebot and keep the database storage there too, wouldn't be too hard.

FWIW I don't think we should rely on being able to reproduce the merges, too annoying if we change the commit message or GitHub changes the raw commit formatting (e.g., different timestamps).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants