Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for integer_atomics #99069

Open
2 tasks
tamird opened this issue Jul 8, 2022 · 8 comments
Open
2 tasks

Tracking issue for integer_atomics #99069

tamird opened this issue Jul 8, 2022 · 8 comments
Labels
A-atomic Area: atomics, barriers, and sync primitives A-concurrency Area: Concurrency related issues. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature.

Comments

@tamird
Copy link
Contributor

tamird commented Jul 8, 2022 •
edited

Tracking rust-lang/rfcs#1543.

  • std::sync::atomic::AtomicI128
  • std::sync::atomic::AtomicU128

Seems related to #56071. See also #57425 which stabilized other atomic integer widths.
@tamird tamird added the C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. label Jul 8, 2022
@tamird tamird mentioned this issue Jul 8, 2022
Merged
Dylan-DPC pushed a commit to Dylan-DPC/rust that referenced this issue Jul 9, 2022
@tamird
Update integer_atomics tracking issue
a491d45 
Updates rust-lang#32976.
Updates rust-lang#99069.
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Jul 9, 2022
@Dylan-DPC
Rollup merge of rust-lang#99070 - tamird:update-tracking-issue, r=Ral…
6816a8d 
…fJung

Update integer_atomics tracking issue

Updates rust-lang#32976.
Updates rust-lang#99069.

r? `@RalfJung`
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Jul 9, 2022
@Dylan-DPC
Rollup merge of rust-lang#99070 - tamird:update-tracking-issue, r=Ral…
3c35da2 
…fJung

Update integer_atomics tracking issue

Updates rust-lang#32976.
Updates rust-lang#99069.

r? ``@RalfJung``
@RalfJung
Copy link
Member

RalfJung commented Jul 9, 2022

It'd be good to list the APIs that are covered by this tracking issue, and copy any open questions that have been noted in the RFC of the previous tracking issue.

JohnTitor pushed a commit to JohnTitor/rust that referenced this issue Jul 26, 2022
@tamird
Update integer_atomics tracking issue
c413617 
Updates rust-lang#32976.
Updates rust-lang#99069.
JohnTitor pushed a commit to JohnTitor/rust that referenced this issue Jul 26, 2022
@Dylan-DPC
Rollup merge of rust-lang#99070 - tamird:update-tracking-issue, r=Ral…
e151a09 
…fJung

Update integer_atomics tracking issue

Updates rust-lang#32976.
Updates rust-lang#99069.

r? ``@RalfJung``
@kadiwa4
Copy link
Contributor

kadiwa4 commented Jul 28, 2022

The unstable ATOMIC_*_INIT constants can be removed, right? Or should they be stabilized for consistency with the stable ATOMIC_*_INIT constants? (All of them are deprecated.)

@workingjubilee workingjubilee added A-concurrency Area: Concurrency related issues. A-atomic Area: atomics, barriers, and sync primitives labels Aug 17, 2022
@kadiwa4 kadiwa4 mentioned this issue Dec 11, 2022
Merged
@eric-seppanen
Copy link

The standard library docs for AtomicU128, etc. still point to #32976 instead of here.

@kadiwa4
Copy link
Contributor

kadiwa4 commented Jan 17, 2023

What do you mean?
image
(rust 1.66.1)

Interestingly, in the online documentation the types don't show up at all, whereas they do show up in my local copy (rust-docs from rustup).

@eric-seppanen
Copy link

Apologies, I must have accidentally followed a link to somebody else's stale docs.

@gitmalong
Copy link

the trait bound std::sync::atomic::AtomicU128: mymod::_::_serde::Deserialize<'_> is not satisfied. Where to fill an issue for that?

bors added a commit to rust-lang-ci/rust that referenced this issue Jul 21, 2023
@bors
Auto merge of rust-lang#105571 - kadiwa4:remove_atomic_init_consts, r…
d26f0b7 
…=Amanieu

remove the unstable `core::sync::atomic::ATOMIC_*_INIT` constants

Tracking issue: rust-lang#99069

It would be weird to ever stabilise these as they are already deprecated.
@HayleyDeckers
Copy link

Now that #120820 has been merged, there are multiple T1 targets that support 128-bit atomics: x86_64-apple-darwin, x86_64-pc-windows-msvc and, x86_64-pc-windows-gnu.

as well as a few lower-tier targets such as aarch64-unknown-linux-musl, arm64e-apple-darwin and aarch64-unknown-uefi .

@HayleyDeckers
Copy link

@m-ou-se @Amanieu Are there any remaining blockers for this that need to be addressed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-atomic Area: atomics, barriers, and sync primitives A-concurrency Area: Concurrency related issues. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@RalfJung @tamird @HayleyDeckers @gitmalong @kadiwa4 @workingjubilee @eric-seppanen