Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta 1.63 breaks calloop 0.4.4 build #98750

Closed
YaLTeR opened this issue Jul 1, 2022 · 5 comments
Closed

Beta 1.63 breaks calloop 0.4.4 build #98750

YaLTeR opened this issue Jul 1, 2022 · 5 comments
Assignees
Labels
C-bug Category: This is a bug. P-critical Critical priority regression-from-stable-to-beta Performance or correctness regression from stable to beta.

Comments

@YaLTeR
Copy link
Contributor

YaLTeR commented Jul 1, 2022

Code

I tried this code: https://github.com/Smithay/calloop/tree/v0.4.4 cargo check

I expected to see this happen: successful build

Instead, this happened: build fails on the new beta (1.63)

error: implementation of `ErasedIdle` is not general enough
  --> src/loop_logic.rs:96:16
   |
96 |         Idle { callback }
   |                ^^^^^^^^ implementation of `ErasedIdle` is not general enough
   |
   = note: `ErasedIdle` would have to be implemented for the type `Option<Box<dyn for<'r> FnMut(&'r mut Data)>>`
   = note: ...but `ErasedIdle` is actually implemented for the type `Option<Box<(dyn FnMut(&'0 mut Data) + 'static)>>`, for some specific lifetime `'0`

Version it worked on

It most recently worked on: Rust 1.62

Version with regression

rustc --version --verbose:

rustc 1.63.0-beta.2 (6c1f14289 2022-06-28)
binary: rustc
commit-hash: 6c1f1428998a08864495bb599840a5997ec175f4
commit-date: 2022-06-28
host: x86_64-unknown-linux-gnu
release: 1.63.0-beta.2
LLVM version: 14.0.5

@rustbot modify labels: +regression-from-stable-to-beta -regression-untriaged

@YaLTeR YaLTeR added C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. labels Jul 1, 2022
@rustbot rustbot added I-prioritize Issue: Indicates that prioritization has been requested for this issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. and removed regression-untriaged Untriaged performance or correctness regression. labels Jul 1, 2022
YaLTeR added a commit to YaLTeR/plitki that referenced this issue Jul 1, 2022
One of its outdated transitive dependencies fails to build on beta:
rust-lang/rust#98750
@apiraino
Copy link
Contributor

apiraino commented Jul 1, 2022

bisection points to commit 10f4ce3 from #98279 cc @cjgillot

searched nightlies: from nightly-2022-04-01 to nightly-2022-07-01
regressed nightly: nightly-2022-06-23
searched commits: from dc80ca7 to 10f4ce3
regressed commit: 10f4ce3

bisected with cargo-bisect-rustc v0.6.0

Host triple: x86_64-unknown-linux-gnu
Reproduce with:

cargo bisect-rustc --start=2022-04-01 --script=./test.sh 

@cjgillot
Copy link
Contributor

cjgillot commented Jul 1, 2022

Will be fixed by a backport of #98637

@cjgillot cjgillot self-assigned this Jul 1, 2022
@pro465
Copy link
Contributor

pro465 commented Jul 1, 2022

ahh, the usual logic bugs. i hope they dont make it into beta or, even worse, stable in future

@apiraino
Copy link
Contributor

apiraino commented Jul 1, 2022

WG-prioritization assigning priority (Zulip discussion).

@rustbot label -I-prioritize +P-critical

@rustbot rustbot added P-critical Critical priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Jul 1, 2022
@Mark-Simulacrum
Copy link
Member

#98637 was backported, closing as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. P-critical Critical priority regression-from-stable-to-beta Performance or correctness regression from stable to beta.
Projects
None yet
Development

No branches or pull requests

6 participants