Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compile-time regression from switch from num_cpus to available_parallelism needs a regression test #98168

Open
pnkfelix opened this issue Jun 16, 2022 · 3 comments
Open

compile-time regression from switch from num_cpus to available_parallelism needs a regression test #98168

pnkfelix opened this issue Jun 16, 2022 · 3 comments
Labels
E-needs-test Call for participation: Writing correctness tests. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@pnkfelix
Copy link
Member

pnkfelix commented Jun 16, 2022 •
edited by rustbot

#97549 flagged a regression injected by PR #94524

The problem was fixed by #97911, but we should try to put a test in somewhere that catches if something similar crops up again.
@pnkfelix pnkfelix added E-needs-test Call for participation: Writing correctness tests. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 16, 2022
@pnkfelix
Copy link
Member Author

See also conversation from triage meeting https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202022-06-16/near/286362341

@reez12g
Copy link
Contributor

reez12g commented Jul 19, 2022

@rustbot claim

@reez12g
Copy link
Contributor

reez12g commented Jul 22, 2022

@rustbot release-assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-needs-test Call for participation: Writing correctness tests. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pnkfelix @reez12g