Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significant increase in compilation time on new version #91830

Closed
zirill opened this issue Dec 12, 2021 · 5 comments
Closed

Significant increase in compilation time on new version #91830

zirill opened this issue Dec 12, 2021 · 5 comments
Labels
C-bug Category: This is a bug. I-compiletime Issue: Problems and improvements with respect to compile times. regression-untriaged Untriaged performance or correctness regression. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@zirill
Copy link

zirill commented Dec 12, 2021

I noticed that there is a dramatic increase in time with each update.

rustc 1.59.0-nightly (928783d 2021-12-11) (or 1.57.0 ~)
Finished release [optimized] target(s) in 25m 28s opt-level=s
Finished release [unoptimized] target(s) in 24m 45s opt-level=0

(in docker 1.56.0)
Finished release [unoptimized] target(s) in 9m 45s opt-level=0
Finished release [unoptimized] target(s) in 8m 42s opt-level=0
Finished release [optimized] target(s) in 10m 16s opt-level=s

+--------------------------------------------------+-----------+-----------------+----------+------------+---------------------------------+
| Item                                             | Self time | % of total time | Time     | Item count | Incremental result hashing time |
+--------------------------------------------------+-----------+-----------------+----------+------------+---------------------------------+
| evaluate_obligation                              | 1082.39s  | 83.132          | 1082.48s | 18959      | 3.64ms                          |
+--------------------------------------------------+-----------+-----------------+----------+------------+---------------------------------+
| codegen_fulfill_obligation                       | 110.69s   | 8.501           | 1179.24s | 6414       | 4.21ms                          |
+--------------------------------------------------+-----------+-----------------+----------+------------+---------------------------------+
| normalize_projection_ty                          | 63.77s    | 4.898           | 63.81s   | 3456       | 10.11ms                         |
+--------------------------------------------------+-----------+-----------------+----------+------------+---------------------------------+
| LLVM_passes                                      | 17.57s    | 1.350           | 17.57s   | 1          | 0.00ns                          |
+--------------------------------------------------+-----------+-----------------+----------+------------+---------------------------------+
| LLVM_module_codegen_emit_obj                     | 9.86s     | 0.757           | 9.86s    | 257        | 0.00ns                          |
+--------------------------------------------------+-----------+-----------------+----------+------------+---------------------------------+
| run_linker                                       | 5.76s     | 0.443           | 5.76s    | 1          | 0.00ns                          |

#91809 (comment)

@Aaron1011
Copy link
Member

PR #90423 was just merged, so tomorrow's nightly should have better performance

@camelid camelid added C-bug Category: This is a bug. I-compiletime Issue: Problems and improvements with respect to compile times. regression-untriaged Untriaged performance or correctness regression. labels Dec 13, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Dec 13, 2021
@camelid camelid added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 13, 2021
@zirill
Copy link
Author

zirill commented Dec 13, 2021

Thank you fantastic!
when will the version be released?

nightly-x86_64-unknown-linux-gnu unchanged - rustc 1.59.0-nightly (6bda5b3 2021-12-12)
Finished release [optimized] target(s) in 2m 57s opt-level=s

@Aaron1011
Copy link
Member

It should be included in the 1.59.0 release (which will be released on February 24).

@apiraino
Copy link
Contributor

removing prioritization label as per Zulip discussion.

@rustbot label -I-prioritize

@rustbot rustbot removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Dec 13, 2021
@apiraino
Copy link
Contributor

I assume this is now fixed 🙂 so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. I-compiletime Issue: Problems and improvements with respect to compile times. regression-untriaged Untriaged performance or correctness regression. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants